[PATCH] D144431: [clang-tidy] Fix readability-identifer-naming Hungarian CString options

Carlos Galvez via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Feb 20 23:43:51 PST 2023


carlosgalvezp added a comment.

Please document fix in the Release Notes, as people might have adopted to the buggy behavior and should know they need to change to the proper one.



================
Comment at: clang-tools-extra/test/clang-tidy/checkers/readability/Inputs/identifier-naming/hungarian-notation2/.clang-tidy:118-125
+    value:  custa
   - key:    readability-identifier-naming.HungarianNotation.DerivedType.Pointer
-    value:  p
+    value:  custp
   - key:    readability-identifier-naming.HungarianNotation.DerivedType.FunctionPointer
-    value:  fn
+    value:  custfn
   - key:    readability-identifier-naming.HungarianNotation.CString.CharPrinter
+    value:  custsz
----------------
These changes generate a lot of review noise and don't seem to be related to the fix in the patch (which has to do with `HungarianNotation.General`. Please revert them and if wanted make another patch just for that.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D144431/new/

https://reviews.llvm.org/D144431



More information about the cfe-commits mailing list