[PATCH] D144431: [clang-tidy] Fix readability-identifer-naming Hungarian CString options
Alexis Murzeau via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Mon Feb 20 14:00:26 PST 2023
amurzeau created this revision.
amurzeau added reviewers: njames93, alexfh, kazu, dougpuob, aaron.ballman, carlosgalvezp.
Herald added a subscriber: xazax.hun.
Herald added a project: All.
amurzeau requested review of this revision.
Herald added subscribers: cfe-commits, aheejin.
Herald added a project: clang-tools-extra.
When reading readability-identifier-naming.HungarianNotation.CString
options, correctly use the type string stored in CStr.second instead of
the option name (CStr.first) as the HNOption.CString map key.
This will make CString options really working and properly parsed by the
checker.
Also adjust identifier-naming-hungarian-notation-cfgfile test with
changes for all configs in .clang-tidy to ensure they are really taken
into account.
Repository:
rG LLVM Github Monorepo
https://reviews.llvm.org/D144431
Files:
clang-tools-extra/clang-tidy/readability/IdentifierNamingCheck.cpp
clang-tools-extra/test/clang-tidy/checkers/readability/Inputs/identifier-naming/hungarian-notation2/.clang-tidy
clang-tools-extra/test/clang-tidy/checkers/readability/identifier-naming-hungarian-notation-cfgfile.cpp
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D144431.498954.patch
Type: text/x-patch
Size: 54749 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20230220/bd66752b/attachment-0001.bin>
More information about the cfe-commits
mailing list