[PATCH] D144192: GH60642: Fix ICE when checking a lambda defined in a concept definition

Nikolas Klauser via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Feb 17 06:32:45 PST 2023


philnik added a comment.

In D144192#4134902 <https://reviews.llvm.org/D144192#4134902>, @erichkeane wrote:

> In D144192#4134900 <https://reviews.llvm.org/D144192#4134900>, @philnik wrote:
>
>> In D144192#4134894 <https://reviews.llvm.org/D144192#4134894>, @erichkeane wrote:
>>
>>> In D144192#4134893 <https://reviews.llvm.org/D144192#4134893>, @philnik wrote:
>>>
>>>> In D144192#4134887 <https://reviews.llvm.org/D144192#4134887>, @erichkeane wrote:
>>>>
>>>>> Looks like I have ot abandon this now?  Anyway, fix was committed, but I forgot the differential-revision line.
>>>>
>>>> You can also Close the revision instead of abandoning it to make it obvious that it has been landed.
>>>
>>> I didn't actually have that option in the "Add Action" section?  I was looking for it, but it seems to have disappeared?
>>
>> I have it on my open revisions, maybe you just missed it?
>
> This is what I have for options on my open revisions (I went and grabbed a snap from a different review): https://imgur.com/a/WYD3uAV
>
> So I don't see 'close' as an option?

Weird. I see a few more options: F26527345: Bildschirmfoto vom 2023-02-17 15-30-33.png <https://reviews.llvm.org/F26527345>


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D144192/new/

https://reviews.llvm.org/D144192



More information about the cfe-commits mailing list