[PATCH] D138453: [clang] Add serialization for loop hint annotation tokens

[Mike Rice via Phabricator via cfe-commits]

mikerice added a comment.

In D138453#4106666 <https://reviews.llvm.org/D138453#4106666>, @aaron.ballman wrote:

> In D138453#4105211 <https://reviews.llvm.org/D138453#4105211>, @DHowett-MSFT wrote:
>
>> 



>> I believe it's expected that we hit this assertion - it's clearer than the original message, and more directly indicates that `#pragma pack` cannot be serialized.
>
> Failed assertions or reaching code marked as unreachable is always a bug -- we should be failing gracefully with diagnostics and not crashing.

My intention is to go through all the pragmas and implement serialization for any that need it. If there are some that we don't want to do or if this takes a long time, I will do ahead and add a diagnostic.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D138453/new/

https://reviews.llvm.org/D138453