[PATCH] D138453: [clang] Add serialization for loop hint annotation tokens

Mon Feb 6 06:41:24 PST 2023

aaron.ballman added a comment.

In D138453#4105211 <https://reviews.llvm.org/D138453#4105211>, @DHowett-MSFT wrote:

> In D138453#4105209 <https://reviews.llvm.org/D138453#4105209>, @shafik wrote:
>
>> It looks like https://github.com/llvm/llvm-project/issues/60543 is hitting your added `llvm_unreachable("missing serialization code for annotation token");` is this expected.
>
> I believe it's expected that we hit this assertion - it's clearer than the original message, and more directly indicates that `#pragma pack` cannot be serialized.

Failed assertions or reaching code marked as unreachable is always a bug -- we should be failing gracefully with diagnostics and not crashing.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D138453/new/

https://reviews.llvm.org/D138453