[PATCH] D141705: [HLSL] [Dirver] add dxv as a Driver Action Job

[Xiang Li via Phabricator via cfe-commits]

python3kgae marked an inline comment as done.
python3kgae added inline comments.


================
Comment at: clang/lib/Driver/Driver.cpp:4218
+    // Only add action when needValidation.
+    if (toolchains::HLSLToolChain::needValidation(Args, *this,
+                                                  C.getDefaultToolChain())) {
----------------
jhuber6 wrote:
> This should work, shouldn't it?
> ```
> const auto &TC = static_cast<const toolchains::HLSLToolChain &>(getToolChain());
> ```
I'm not sure getToolChain will return a HLSLToolChain.
Is it OK to use dynamic_cast?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D141705/new/

https://reviews.llvm.org/D141705