[PATCH] D141705: [HLSL] [Dirver] add dxv as a Driver Action Job

[Joseph Huber via Phabricator via cfe-commits]

jhuber6 added inline comments.


================
Comment at: clang/lib/Driver/Driver.cpp:4214-4216
+  // Call validator for dxil when -Vd not in Args.
+  llvm::Triple T(getTargetTriple());
+  if (T.getArch() == llvm::Triple::dxil) {
----------------



================
Comment at: clang/lib/Driver/Driver.cpp:4218
+    // Only add action when needValidation.
+    if (toolchains::HLSLToolChain::needValidation(Args, *this,
+                                                  C.getDefaultToolChain())) {
----------------
This should work, shouldn't it?
```
const auto &TC = static_cast<const toolchains::HLSLToolChain &>(getToolChain());
```


================
Comment at: clang/test/Driver/dxc_dxv_path.hlsl:14-15
+// RUN: %clang_dxc -Tlib_6_3 -ccc-print-bindings --dxv-path=%T -Fo %t.dxc  %s 2>&1 | FileCheck %s --check-prefix=BINDINGS
+// BINDINGS: "dxil-unknown-shadermodel6.3-library" - "clang", inputs: ["[[INPUT:.+]]"], output: "[[DXC:.+]].dxc"
+// BINDINGS: "dxil-unknown-shadermodel6.3-library" - "hlsl::Validator", inputs: ["[[DXC]].dxc"], output: "[[DXC]].dxc"
+
----------------
nit


================
Comment at: clang/test/Driver/dxc_dxv_path.hlsl:19-23
+// PHASES:+- 0: input, "[[INPUT:.+]]", hlsl
+// PHASES:+- 1: preprocessor, {0}, c++-cpp-output
+// PHASES:+- 2: compiler, {1}, ir
+// PHASES:3: backend, {2}, assembler
+// PHASES:4: binary-analyzer, {3}, dx-container
----------------



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D141705/new/

https://reviews.llvm.org/D141705