[PATCH] D141625: [DeclContext] Sort the Decls before adding into DeclContext

Thu Jan 19 15:23:56 PST 2023

dblaikie added a comment.

In D141625#4066961 <https://reviews.llvm.org/D141625#4066961>, @steven_wu wrote:

> No, reverse iteration will not break diff test for a small number of decls. Everything will be in reverse order so it is the same.

Hmm, I'm not sure I'm following why that is - could you explain this in more detail? The usual problem is that, say, we're outputting based on an unstable order - even two items would be enough to cause a test of that to fail in either forward or reverse iteration mode until the order is stabilized.

Is that not the case here? Is there some interaction between iteration order that's part of the nondeterminism here?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D141625/new/

https://reviews.llvm.org/D141625