[PATCH] D141862: [clang][driver][AIX] Add OpenMP runtime if -fopenmp specified

[Xing Xue via Phabricator via cfe-commits]

xingxue added inline comments.


================
Comment at: clang/test/Driver/aix-ld.c:1027
+// RUN:        -fopenmp \
+// RUN:   | FileCheck --check-prefix=CHECK-FOPENMP-OMP %s
+// CHECK-FOPENMP-OMP-NOT: warning:
----------------
daltenty wrote:
> nit: since the output for these tests are really the same, apart from one line with the library name, we could use two prefixes, a common one and a specific one to avoid repetition:
> ```
> // RUN:   | FileCheck --check-prefixes=CHECK-FOPENMP,CHECK-FOPENMP-OMP %s
> ```
> 
> and then the CHECK block can go something like this:
> ```
> ...
> // CHECK-FOPENMP-NOT: "-lm"
> // CHECK-FOPENMP-OMP:     "-lomp"
> // CHECK-FOPENMP-IOMP5:  "-liomp5"
> // CHECK-FOPENMP-GOMP:   "-lgomp
> // CHECK-FOPENMP:     "-lc"
> ...
> ```
Good suggestion, thanks!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D141862/new/

https://reviews.llvm.org/D141862