[PATCH] D141862: [clang][driver][AIX] Add OpenMP runtime if -fopenmp specified

David Tenty via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Jan 19 08:44:39 PST 2023


daltenty accepted this revision.
daltenty added a comment.
This revision is now accepted and ready to land.

Some minor nits about how we can shorten the test, but otherwise LGTM



================
Comment at: clang/test/Driver/aix-ld.c:1027
+// RUN:        -fopenmp \
+// RUN:   | FileCheck --check-prefix=CHECK-FOPENMP-OMP %s
+// CHECK-FOPENMP-OMP-NOT: warning:
----------------
nit: since the output for these tests are really the same, apart from one line with the library name, we could use two prefixes, a common one and a specific one to avoid repetition:
```
// RUN:   | FileCheck --check-prefixes=CHECK-FOPENMP,CHECK-FOPENMP-OMP %s
```

and then the CHECK block can go something like this:
```
...
// CHECK-FOPENMP-NOT: "-lm"
// CHECK-FOPENMP-OMP:     "-lomp"
// CHECK-FOPENMP-IOMP5:  "-liomp5"
// CHECK-FOPENMP-GOMP:   "-lgomp
// CHECK-FOPENMP:     "-lc"
...
```


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D141862/new/

https://reviews.llvm.org/D141862



More information about the cfe-commits mailing list