[PATCH] D141855: [include-mapping] Parse zombie_names.html into a removed symbols map.

[Haojian Wu via Phabricator via cfe-commits]

hokein added a comment.

mostly good, just nits.



================
Comment at: clang/tools/include-mapping/gen_std.py:31
        // Generate C++ symbols
        python3 gen_std.py -cppreference cppreference/reference -language=cpp > StdSymbolMap.inc
        // Generate C symbols
----------------
nit: update the doc.


================
Comment at: clang/tools/include-mapping/gen_std.py:94
     parse_pages = [(page_root, "index.html", None)]
-
+  elif args.symbols == 'cppremoved':
+    page_root = os.path.join(args.cppreference, "en", "cpp")
----------------
nit: can we add a `_` between `cpp` and `removed`. And maybe move it after the if `args.symbols == 'cpp'` branch as they are `cpp` related.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D141855/new/

https://reviews.llvm.org/D141855