[PATCH] D141855: [include-mapping] Parse zombie_names.html into a removed symbols map.

Viktoriia Bakalova via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Jan 17 08:00:46 PST 2023


VitaNuo marked an inline comment as done.
VitaNuo added a comment.

Yes, ofc I've run it, I wouldn't send a patch otherwise :)



================
Comment at: clang/tools/include-mapping/gen_std.py:67
                       required=True)
+  parser.add_argument('-output',
+                      default='SymbolMap.inc',
----------------
hokein wrote:
> instead adding two CLI flags, I'd suggest extending the existing `language` flag to something like `-symbols = {cpp_symbols, c_symbols, cpp_removed_symbols}`, it is easy to extend in the future (e.g. `c_removed_symbols`).
> 
Sure, good idea!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D141855/new/

https://reviews.llvm.org/D141855



More information about the cfe-commits mailing list