[PATCH] D141787: [clang-tidy] fix a false positive of `modernize-concat-nested-namespaces`

[Vincent Hong via Phabricator via cfe-commits]

v1nh1shungry added inline comments.


================
Comment at: clang-tools-extra/test/clang-tidy/checkers/modernize/concat-nested-namespaces.cpp:173
+namespace n48 {
+// CHECK-MESSAGES-DAG: :[[@LINE-2]]:1: warning: nested namespaces can be concatenated [modernize-concat-nested-namespaces]
+// CHECK-FIXES: namespace n47::n48
----------------
njames93 wrote:
> Is `CHECK-MESSAGES-DAG` needed here, why does it fail if this is omitted?
Hmm, doesn't `CHECK-MESSAGES-DAG` means to check whether there is a message? (I referred to the tests above.)

If it's other cases, maybe it's due to https://github.com/llvm/llvm-project/issues/60051.

I'm not sure I understand what you mean, sorry!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D141787/new/

https://reviews.llvm.org/D141787