[PATCH] D141787: [clang-tidy] fix a false positive of `modernize-concat-nested-namespaces`

Nathan James via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Sun Jan 15 14:14:23 PST 2023


njames93 requested changes to this revision.
njames93 added inline comments.
This revision now requires changes to proceed.


================
Comment at: clang-tools-extra/test/clang-tidy/checkers/modernize/concat-nested-namespaces.cpp:173
+namespace n48 {
+// CHECK-MESSAGES-DAG: :[[@LINE-2]]:1: warning: nested namespaces can be concatenated [modernize-concat-nested-namespaces]
+// CHECK-FIXES: namespace n47::n48
----------------
Is `CHECK-MESSAGES-DAG` needed here, why does it fail if this is omitted?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D141787/new/

https://reviews.llvm.org/D141787



More information about the cfe-commits mailing list