[PATCH] D139737: [-Wunsafe-buffer-usage] Initiate Fix-it generation for local variable declarations

Jan Korous via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Jan 11 12:41:03 PST 2023


jkorous added a comment.

In D139737#4042093 <https://reviews.llvm.org/D139737#4042093>, @NoQ wrote:

> It sounds to me as if by landing the patch we'll temporarily make the compiler emit incorrect fixes. I think we should avoid doing that. Is it possible to wait until our first proof-of-concept `FixableGadget` lands before landing this patch? I think there shouldn't be too much conflict between such patches.

Any patch with `FixableGadget` will face the same problem - i. e. we still won't emit the fixit until this patch has landed.
We decided to include a simple `Fixable` in this patch to unlock testing.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D139737/new/

https://reviews.llvm.org/D139737



More information about the cfe-commits mailing list