[PATCH] D139737: [-Wunsafe-buffer-usage] Initiate Fix-it generation for local variable declarations
Artem Dergachev via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Tue Jan 10 17:54:25 PST 2023
NoQ added a comment.
In D139737#4037455 <https://reviews.llvm.org/D139737#4037455>, @ziqingluo-90 wrote:
> Since we do not have any `FixableGadget` to trigger fix-its at this point, I let fix-its of local variable declarations always be emitted for the purpose of testing.
It sounds to me as if by landing the patch we'll temporarily make the compiler emit incorrect fixes. I think we should avoid doing that. Is it possible to wait until our first proof-of-concept `FixableGadget` lands before landing this patch? I think there shouldn't be too much conflict between such patches.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D139737/new/
https://reviews.llvm.org/D139737
More information about the cfe-commits
mailing list