[PATCH] D141206: [clang] [MinGW] Avoid adding <base>/include and <base>/lib when cross compiling

Sun Jan 8 14:38:04 PST 2023

mati865 added a comment.

In D141206#4034451 <https://reviews.llvm.org/D141206#4034451>, @mstorsjo wrote:

> In D141206#4034159 <https://reviews.llvm.org/D141206#4034159>, @mati865 wrote:
>
>> I had thought we do that already so this change looks reasonable for me.
>> Just one thought, do we support multilib toolchains? I think in that case Clang would have to add `<base>/include` despite different triple.
>
> This patch actually does that already, see the parameter `RequireArchMatch` which is set to true for the `<base>/lib` case and false for `<base>/include`.

Ah, I have messed up those 2.
I haven't seen multilib mingw-w64 distribution either but just wanted to be cautious here to not accidentally regress if there is somebody doing that.
Then I cannot think of any issues this patch could cause.

BTW Looking at Arch Linux 32-bit libs are placed in `<some_lib_dir>/32` but this is off-topic.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D141206/new/

https://reviews.llvm.org/D141206