[PATCH] D141206: [clang] [MinGW] Avoid adding <base>/include and <base>/lib when cross compiling

Sun Jan 8 13:08:08 PST 2023

mstorsjo added a comment.

In D141206#4034451 <https://reviews.llvm.org/D141206#4034451>, @mstorsjo wrote:

> In D141206#4034159 <https://reviews.llvm.org/D141206#4034159>, @mati865 wrote:
>
>> I had thought we do that already so this change looks reasonable for me.
>> Just one thought, do we support multilib toolchains? I think in that case Clang would have to add `<base>/include` despite different triple.
>
> This patch actually does that already, see the parameter `RequireArchMatch` which is set to true for the `<base>/lib` case and false for `<base>/include`.

... but thanks for considering and bringing up that case, I hadn't really thought much about that - I don't see multilib setups that often actually. Not sure if and/or how well they work with clang.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D141206/new/

https://reviews.llvm.org/D141206