[PATCH] D141000: [clang-tidy] Introduce HeaderFileExtensions option

Carlos Galvez via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Jan 6 02:44:59 PST 2023


carlosgalvezp added a comment.

I found now what this global `User` option is about:

  /// Specifies the name or e-mail of the user running clang-tidy.
  ///
  /// This option is used, for example, to place the correct user name in TODO()
  /// comments in the relevant check.
  std::optional<std::string> User;

So it seems to me it's an option used only in one check, and yet it's a global option. Based on that I think it's reasonable to have `HeaderFileExtensions` and `ImplementationFileExtensions` (which are shared among multiple checks) as global as well. It doesn't need to be a CLI option, config-only is fine.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D141000/new/

https://reviews.llvm.org/D141000



More information about the cfe-commits mailing list