[PATCH] D141000: [clang-tidy] Introduce HeaderFileExtensions option

Carlos Galvez via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Jan 6 02:29:15 PST 2023


carlosgalvezp added a comment.

On a second thought, using `getLocalOrGlobal` would still require all checks to have 2 private member variables (the raw string option and the parsed header option), together with the logic in the constructor to get the option an parse that. I would like to get rid of all that as well, ideally every check should simply call a function "bool isInHeaderFile(Location)" or "bool isInImplementationFile(Location)". Keeping those private variables to get a global option is also a bit inconsistent with the rest of checks and might cause confusion. What do you think?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D141000/new/

https://reviews.llvm.org/D141000



More information about the cfe-commits mailing list