[PATCH] D140639: clang: Fix handling of __builtin_elementwise_copysign

[Erich Keane via Phabricator via cfe-commits]

erichkeane added inline comments.


================
Comment at: clang/lib/Sema/SemaChecking.cpp:2674
+
+    if (MagnitudeTy.getCanonicalType() != SignTy.getCanonicalType()) {
+      return Diag(Sign.get()->getBeginLoc(),
----------------
arsenm wrote:
> erichkeane wrote:
> > curleys not used for single-statement if-statement bodies.
> It covers 3 lines, it should have braces
Our standard says 'statments' not 'lines'.  This is a single statement.

https://llvm.org/docs/CodingStandards.html#don-t-use-braces-on-simple-single-statement-bodies-of-if-else-loop-statements


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D140639/new/

https://reviews.llvm.org/D140639