[PATCH] D140639: clang: Fix handling of __builtin_elementwise_copysign

Matt Arsenault via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Jan 5 09:09:05 PST 2023


arsenm added inline comments.


================
Comment at: clang/lib/Sema/SemaChecking.cpp:2674
+
+    if (MagnitudeTy.getCanonicalType() != SignTy.getCanonicalType()) {
+      return Diag(Sign.get()->getBeginLoc(),
----------------
erichkeane wrote:
> curleys not used for single-statement if-statement bodies.
It covers 3 lines, it should have braces


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D140639/new/

https://reviews.llvm.org/D140639



More information about the cfe-commits mailing list