[PATCH] D140155: [Clang][OpenMP] Allow host call to nohost function with host variant

[Gheorghe-Teodor Bercea via Phabricator via cfe-commits]

doru1004 added a comment.

In D140155#4016333 <https://reviews.llvm.org/D140155#4016333>, @jhuber6 wrote:

> In D140155#4016274 <https://reviews.llvm.org/D140155#4016274>, @mgorny wrote:
>
>> In D140155#4004505 <https://reviews.llvm.org/D140155#4004505>, @doru1004 wrote:
>>
>>> Commit 658ed9547cdd6657895339a6c390c31aa77a5698 <https://reviews.llvm.org/rG658ed9547cdd6657895339a6c390c31aa77a5698>
>>
>> The added test fails on 32-bit platforms:
>>
>>   FAIL: Clang :: OpenMP/declare_target_nohost_variant_messages.cpp (10230 of 16135)
>>   ******************** TEST 'Clang :: OpenMP/declare_target_nohost_variant_messages.cpp' FAILED ********************
>>   Script:
>>   --
>>   : 'RUN: at line 3';   /var/tmp/portage/sys-devel/clang-16.0.0_pre20221225/work/x/y/clang-abi_x86_32.x86/bin/clang -cc1 -internal-isystem /var/tmp/portage/sys-devel/clang-16.0.0_pre20221225/work/x/y/clang-abi_x86_32.x86/bin/../../../../lib/clang/16/include -nostdsysteminc -fopenmp -fopenmp-targets=amdgcn-amd-amdhsa -fopenmp-version=52 -DVERBOSE_MODE=1 -verify=omp52 -fnoopenmp-use-tls -ferror-limit 100 -fopenmp-targets=amdgcn-amd-amdhsa -o - /var/tmp/portage/sys-devel/clang-16.0.0_pre20221225/work/clang/test/OpenMP/declare_target_nohost_variant_messages.cpp
>>   --
>>   Exit Code: 1
>>   
>>   Command Output (stderr):
>>   --
>>   + : 'RUN: at line 3'
>>   + /var/tmp/portage/sys-devel/clang-16.0.0_pre20221225/work/x/y/clang-abi_x86_32.x86/bin/clang -cc1 -internal-isystem /var/tmp/portage/sys-devel/clang-16.0.0_pre20221225/work/x/y/clang-abi_x86_32.x86/bin/../../../../lib/clang/16/include -nostdsysteminc -fopenmp -fopenmp-targets=amdgcn-amd-amdhsa -fopenmp-version=52 -DVERBOSE_MODE=1 -verify=omp52 -fnoopenmp-use-tls -ferror-limit 100 -fopenmp-targets=amdgcn-amd-amdhsa -o - /var/tmp/portage/sys-devel/clang-16.0.0_pre20221225/work/clang/test/OpenMP/declare_target_nohost_variant_messages.cpp
>>   error: 'error' diagnostics seen but not expected: 
>>     (frontend): OpenMP target architecture 'amdgcn-amd-amdhsa' pointer size is incompatible with host 'i686-pc-linux-gnu'
>>   
>>   --
>>   
>>   ********************
>>
>> Please fix, or ideally revert, fix and then commit properly linking to the diff.
>
> Should be fixed in rGf74e3d2f81d2 <https://reviews.llvm.org/rGf74e3d2f81d2aae47d6032fc1d23114460d48a37>.

Thank you for pushing a fix!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D140155/new/

https://reviews.llvm.org/D140155