[PATCH] D140894: [clang-tidy] Don't emit misc-unused-using-decl warnings for header files.

Eugene Zelenko via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Jan 3 08:06:19 PST 2023


Eugene.Zelenko added inline comments.


================
Comment at: clang-tools-extra/docs/clang-tidy/checks/misc/unused-using-decls.rst:26
+   A semicolon-separated list of filename extensions of header files (the filename
+   extensions should not include "." prefix). Default is ";h;hh;hpp;hxx".
+   For extension-less header files, using an empty string or leaving an
----------------
ymandel wrote:
> Eugene.Zelenko wrote:
> > Please use single back-ticks for option values.
> > 
> > Actually this is second patch with similar functionality during last month and I think this option should be shared between all checks.
> Eugene -- are you suggesting that is a blocker on this patch, or just a good idea for clang-tidy in general?
Sure, it'll be better to do this as separate patch, but this should be done at some point. It;s both code duplication and more complex complex setup for users.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D140894/new/

https://reviews.llvm.org/D140894



More information about the cfe-commits mailing list