[PATCH] D140894: [clang-tidy] Don't emit misc-unused-using-decl warnings for header files.

[Yitzhak Mandelbaum via Phabricator via cfe-commits]

ymandel accepted this revision.
ymandel added a comment.
This revision is now accepted and ready to land.

Thanks!



================
Comment at: clang-tools-extra/clang-tidy/misc/UnusedUsingDeclsCheck.cpp:48
+                                  HeaderFileExtensions,
+                                  utils::defaultFileExtensionDelimiters())) {
+    this->configurationDiag("Invalid header file extension: '%0'")
----------------
nit: no need for braces on the if statement.


================
Comment at: clang-tools-extra/docs/clang-tidy/checks/misc/unused-using-decls.rst:26
+   A semicolon-separated list of filename extensions of header files (the filename
+   extensions should not include "." prefix). Default is ";h;hh;hpp;hxx".
+   For extension-less header files, using an empty string or leaving an
----------------
Eugene.Zelenko wrote:
> Please use single back-ticks for option values.
> 
> Actually this is second patch with similar functionality during last month and I think this option should be shared between all checks.
Eugene -- are you suggesting that is a blocker on this patch, or just a good idea for clang-tidy in general?


================
Comment at: clang-tools-extra/docs/clang-tidy/checks/misc/unused-using-decls.rst:27
+   extensions should not include "." prefix). Default is ";h;hh;hpp;hxx".
+   For extension-less header files, using an empty string or leaving an
+   empty string between ";" if there are other filename extensions.
----------------



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D140894/new/

https://reviews.llvm.org/D140894