[PATCH] D140753: [clang][dataflow] Check both operand's type in mergeDistinctValues

[Jun Zhang via Phabricator via cfe-commits]

junaire added a comment.

In D140753#4019322 <https://reviews.llvm.org/D140753#4019322>, @gribozavr2 wrote:

> Thank you for your contribution!
>
> While adding a conditional check fixes the crash, the problem's root cause must be deeper. Mismatched types indicate that one code path in dataflow analysis computes a bool type for a storage location, while a different code path computes an integer type. That's the actual root cause. Could you try to investigate the reasons for that, and try to fix it? The dataflow analysis should be computing values of the same type no matter through which path we arrived at a program point.

Thanks for your thoughts about the bug. Sure I'd love to try to investigate and will let you know what I finally got :)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D140753/new/

https://reviews.llvm.org/D140753