[PATCH] D140753: [clang][dataflow] Check both operand's type in mergeDistinctValues

[Dmitri Gribenko via Phabricator via cfe-commits]

gribozavr2 requested changes to this revision.
gribozavr2 added a comment.
This revision now requires changes to proceed.

Thank you for your contribution!

While adding a conditional check fixes the crash, the problem's root cause must be deeper. Mismatched types indicate that one code path in dataflow analysis computes a bool type for a storage location, while a different code path computes an integer type. That's the actual root cause. Could you try to investigate the reasons for that, and try to fix it? The dataflow analysis should be computing values of the same type no matter through which path we arrived at a program point.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D140753/new/

https://reviews.llvm.org/D140753