[PATCH] D139087: [include-cleaner] Handle base class member access from derived class.

Viktoriia Bakalova via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Dec 8 02:36:39 PST 2022


VitaNuo added inline comments.


================
Comment at: clang-tools-extra/include-cleaner/lib/WalkAST.cpp:67
 
   bool VisitMemberExpr(MemberExpr *E) {
+    // A member expr implies a usage of the class type
----------------
hokein wrote:
> while reading it again, I realize that there is another case (operator overloading) we probably want to handle it as well. It is a more tricky case, no need to worry about it in this patch. 
> 
Thank you. If you'd like me to take care of it, please file an issue with an example that needs to be taken care of :)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D139087/new/

https://reviews.llvm.org/D139087



More information about the cfe-commits mailing list