[PATCH] D139087: [include-cleaner] Handle base class member access from derived class.

[Haojian Wu via Phabricator via cfe-commits]

hokein accepted this revision.
hokein added a comment.
This revision is now accepted and ready to land.

Thanks, looks good.

Add a `Fix <github issue link>` in the commit message.



================
Comment at: clang-tools-extra/include-cleaner/lib/WalkAST.cpp:67
 
   bool VisitMemberExpr(MemberExpr *E) {
+    // A member expr implies a usage of the class type
----------------
while reading it again, I realize that there is another case (operator overloading) we probably want to handle it as well. It is a more tricky case, no need to worry about it in this patch. 



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D139087/new/

https://reviews.llvm.org/D139087