[PATCH] D138821: [include-cleaner] Remove filtering from UsingDecl visit.
    Haojian Wu via Phabricator via cfe-commits 
    cfe-commits at lists.llvm.org
       
    Thu Dec  8 01:53:11 PST 2022
    
    
  
hokein accepted this revision.
hokein added a comment.
This revision is now accepted and ready to land.
Thanks.
You can add a `Fix: https://github.com/llvm/llvm-project/issues/59147` in the commit message, it will automatically close the github issue when you commit the patch.
================
Comment at: clang-tools-extra/include-cleaner/unittests/WalkASTTest.cpp:144
+      class $ambiguous^Y {};
+    }
+    )cpp",
----------------
nit: merge the following line with this line, `})cpp"`
================
Comment at: clang-tools-extra/include-cleaner/unittests/WalkASTTest.cpp:152
+    }
+   using ns::$explicit^Y; 
+    )cpp",
----------------
nit: fix the alignment  
================
Comment at: clang-tools-extra/include-cleaner/unittests/WalkASTTest.cpp:153
+   using ns::$explicit^Y; 
+    )cpp",
+           "^Y<int> x;");
----------------
nit: and here as well.
Repository:
  rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D138821/new/
https://reviews.llvm.org/D138821
    
    
More information about the cfe-commits
mailing list