[PATCH] D138821: [include-cleaner] Remove filtering from UsingDecl visit.

[Viktoriia Bakalova via Phabricator via cfe-commits]

VitaNuo marked 2 inline comments as done.
VitaNuo added inline comments.


================
Comment at: clang-tools-extra/include-cleaner/unittests/WalkASTTest.cpp:130
 TEST(WalkAST, Using) {
-  // Make sure we ignore unused overloads.
+  // We should report unused overloads as ambiguous.
   testWalk(R"cpp(
----------------
hokein wrote:
> hokein wrote:
> > nit: update the comment.
> this comment is stale, and the below one as well.
oops, sorry.


================
Comment at: clang-tools-extra/include-cleaner/unittests/WalkASTTest.cpp:149
+  // We should report references to templates as ambiguous.
+  testWalk(R"cpp(
+    namespace ns {
----------------
VitaNuo wrote:
> kadircet wrote:
> > sorry if i am being dense but what's the difference we're trying to grasp between this and the next test case exactly?
> > i guess it's meant to test the difference between used and non-used template patterns?
> Yes, you're right. It probably only made sense before I removed the "isUsed" check.
I have re-introduced this test case now, since there's a differentiation between used and unused again.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D138821/new/

https://reviews.llvm.org/D138821