[PATCH] D138792: [AArch64] Improve TargetParser API

[Jonas Hahnfeld via Phabricator via cfe-commits]

Hahnfeld added a comment.

In D138792#3969310 <https://reviews.llvm.org/D138792#3969310>, @mgorny wrote:

> In D138792#3966920 <https://reviews.llvm.org/D138792#3966920>, @Hahnfeld wrote:
>
>> Hi, I bisected this change to lead to a couple of test failures when building with `LLVM_LINK_LLVM_DYLIB`. In the past, this had to do with global variable initialization order, but nothing immediately jumps to my eye in this patch. Is `AARCH64_ARCH` used to define global variables?
>
> Did you hit these?
>
>   Failed Tests (4):
>     Clang :: Driver/aarch64-target-as-march.s
>     Clang :: Misc/target-invalid-cpu-note.c
>     Clang :: Preprocessor/aarch64-target-features.c
>     Clang :: Sema/attr-target.c
>
> I've just bisected them to this commit, so I guess yes.

Yes, these are the ones I see in my "default" configuration (`RelWithDebInfo` and assertions turned on). If I however modify my `Release` configuration to add `LLVM_LINK_LLVM_DYLIB`, I see the following 9 failures:

  Failed Tests (9):
    Clang :: Driver/aarch64-march.c
    Clang :: Driver/aarch64-sve.c
    Clang :: Driver/aarch64-sve2.c
    Clang :: Driver/aarch64-target-as-march.s
    Clang :: Driver/aarch64-v91a.c
    Clang :: Driver/aarch64-v92a.c
    Clang :: Misc/target-invalid-cpu-note.c
    Clang :: Preprocessor/aarch64-target-features.c
    Clang :: Sema/attr-target.c

It's not entirely clear to me why there are more failing tests...


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D138792/new/

https://reviews.llvm.org/D138792