[PATCH] D138792: [AArch64] Improve TargetParser API

Michał Górny via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Sun Dec 4 09:07:18 PST 2022


mgorny added a comment.

In D138792#3966920 <https://reviews.llvm.org/D138792#3966920>, @Hahnfeld wrote:

> Hi, I bisected this change to lead to a couple of test failures when building with `LLVM_LINK_LLVM_DYLIB`. In the past, this had to do with global variable initialization order, but nothing immediately jumps to my eye in this patch. Is `AARCH64_ARCH` used to define global variables?

Did you hit these?

  Failed Tests (4):
    Clang :: Driver/aarch64-target-as-march.s
    Clang :: Misc/target-invalid-cpu-note.c
    Clang :: Preprocessor/aarch64-target-features.c
    Clang :: Sema/attr-target.c

I've just bisected them to this commit, so I guess yes.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D138792/new/

https://reviews.llvm.org/D138792



More information about the cfe-commits mailing list