[PATCH] D135841: [clang][deps][lex] Avoid canonicalization of remapped framework directories

Ben Langmuir via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Dec 1 16:22:04 PST 2022


benlangmuir added inline comments.


================
Comment at: clang/lib/Lex/ModuleMap.cpp:1331
+    auto CanonicalDirEntry = FM.getDirectory(CanonicalDir);
+    if (CanonicalDirEntry && *CanonicalDirEntry == *DirEntry) {
+      bool Done = llvm::sys::path::replace_path_prefix(Path, Dir, CanonicalDir);
----------------
benlangmuir wrote:
> Wouldn't this indicate the particular VFS has a bug? 
^ Sorry this question was an old draft, you can disregard.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D135841/new/

https://reviews.llvm.org/D135841



More information about the cfe-commits mailing list