[PATCH] D135841: [clang][deps][lex] Avoid canonicalization of remapped framework directories

[Ben Langmuir via Phabricator via cfe-commits]

benlangmuir accepted this revision.
benlangmuir added a comment.
This revision is now accepted and ready to land.

Please add a comment about why this equality check is necessary.



================
Comment at: clang/lib/Lex/ModuleMap.cpp:1331
+    auto CanonicalDirEntry = FM.getDirectory(CanonicalDir);
+    if (CanonicalDirEntry && *CanonicalDirEntry == *DirEntry) {
+      bool Done = llvm::sys::path::replace_path_prefix(Path, Dir, CanonicalDir);
----------------
Wouldn't this indicate the particular VFS has a bug? 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D135841/new/

https://reviews.llvm.org/D135841