[PATCH] D133633: [CMake] Add ClangBootstrap configuration

[Amir Ayupov via Phabricator via cfe-commits]

Amir added inline comments.


================
Comment at: clang/cmake/modules/ClangBootstrap.cmake:11
+macro(clang_bootstrap_add name)
+  cmake_parse_arguments(ARG "" "LINKER;AR;RANLIB;OBJCOPY;STRIP"
+    "DEPENDS;TABLEGEN;CMAKE_ARGS;BUILD_TOOL_ARGS"
----------------
thevinster wrote:
> Were you planning to also use the single arguments list such as `ARG_LINKER` in the `CMAKE_ARGS`? Without it, I have to supply an override to `CLANG_BOLT_INSTRUMENT_EXTRA_CMAKE_FLAGS` so I can avoid using the gnu linker.
Yes, I added those in the first version of the diff and just forgot to remove them. But as Peter mentioned:
> I don't think we need a dedicated keyword for each tool, I'd just pass these through CMAKE_ARGS.
I'm neutral about adding ARG_LINKER or setting it through EXTRA_CMAKE_FLAGS, but I think explicit overrides for each tool are a bit too verbose. 
Do you think having ARG_LINKER and passing the rest as EXTRA_CMAKE_FLAGS is a good tradeoff? cc @phosek 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D133633/new/

https://reviews.llvm.org/D133633