[PATCH] D133633: [CMake] Add ClangBootstrap configuration

Vincent Lee via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Nov 22 23:00:23 PST 2022


thevinster added inline comments.


================
Comment at: clang/cmake/modules/ClangBootstrap.cmake:11
+macro(clang_bootstrap_add name)
+  cmake_parse_arguments(ARG "" "LINKER;AR;RANLIB;OBJCOPY;STRIP"
+    "DEPENDS;TABLEGEN;CMAKE_ARGS;BUILD_TOOL_ARGS"
----------------
Were you planning to also use the single arguments list such as `ARG_LINKER` in the `CMAKE_ARGS`? Without it, I have to supply an override to `CLANG_BOLT_INSTRUMENT_EXTRA_CMAKE_FLAGS` so I can avoid using the gnu linker.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D133633/new/

https://reviews.llvm.org/D133633



More information about the cfe-commits mailing list