[PATCH] D138546: Clangd: Preserve target flags in system includes extractor

Christopher Sauer via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Nov 23 01:47:39 PST 2022

cpsauer added a comment.

Sam, my read, too, is that the memoizing design isn't safe--also that the key bug is preexisting.

I had the same reaction reading through this file after spotting problems in the log. That's what spawned https://github.com/clangd/clangd/issues/1378.

Any chance I could get you to quickly read through that issue if you haven't already? (The relevant section to this part: "If we think sysroots, targets, and the other flags enumerated effect the system includes, we'd better include them as part of the memoization key.")

There are sadly *lots* of problems in this file that leap out on a quick read. Nathan and I were thinking, though, that we'd should post this incremental fix for review rather than getting bogged down in trying to fix multiple things atomically.

  rG LLVM Github Monorepo



More information about the cfe-commits mailing list