[PATCH] D138546: Clangd: Preserve target flags in system includes extractor

Sam McCall via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Nov 23 01:24:16 PST 2022


sammccall added a comment.

My biggest concern here is propagating more information here without including it in the cache key.
Originally the computation was strictly using the cache key as input, but started using the command-line flags in D73453 <https://reviews.llvm.org/D73453>. @kadircet any extra context on when/why this is safe?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D138546/new/

https://reviews.llvm.org/D138546



More information about the cfe-commits mailing list