[PATCH] D137024: [compiler-rt] Switch from llvm-config to find_package(LLVM)

[Michał Górny via Phabricator via cfe-commits]

mgorny added a comment.

In D137024#3931126 <https://reviews.llvm.org/D137024#3931126>, @thetruestblue wrote:

> This patch removes the logic that sets the binary tools dir using llvm-config. We don't have llvmConfig.cmake in our toolchain or our build tree and relied on llvm-config to 
> set(LLVM_TOOLS_BINARY_DIR "${LLVM_TOOLS_BINARY_DIR}"directory.

While I sympathize with you, I don't think this is valid reason to maintain full compatibility with `llvm-config`. Unless i'm mistaken, its use for building other LLVM projects standalone was deprecated for a few years already, and compiler-rt was the last project to carry the compatibility code. Furthermore, skipping cmake files from LLVM seems wrong.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D137024/new/

https://reviews.llvm.org/D137024