[PATCH] D137024: [compiler-rt] Switch from llvm-config to find_package(LLVM)
Brittany Blue Gaston via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Wed Nov 16 09:13:25 PST 2022
thetruestblue added a comment.
This breaks our use case. We run sanitizer tests built in a standalone build using an artifact toolchain that contains binaries only.
Compiler-rt tests rely on the llvm tools binary being in the PATH.
This patch removes the logic that sets the binary tools dir using llvm-config. We don't have llvmConfig.cmake in our toolchain relied on llvm-config to
set(LLVM_TOOLS_BINARY_DIR "${LLVM_TOOLS_BINARY_DIR}"directory.
We can work around this by setting the LLVM_TOOLS_BINARY_DIR directly (and potentially other paths... tbd).
But I think we need to reactor this cmake file so that this is considered a valid code path.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D137024/new/
https://reviews.llvm.org/D137024
More information about the cfe-commits
mailing list