[PATCH] D129156: Add -fpass-plugin option to Flang

Thu Nov 10 06:37:48 PST 2022

tarunprabhu marked 2 inline comments as done.
tarunprabhu added a comment.

Yes, I am aware of the other patch which also adds `test/Driver/pass-plugin.f90`. I will keep an eye out for it.

================
Comment at: flang/test/CMakeLists.txt:65
 )
+if (NOT WIN32)
+  list(APPEND FLANG_TEST_DEPENDS Bye)
----------------
awarzynski wrote:
> awarzynski wrote:
> > IIUC, `Bye` is only needed when plugins are enabled.
> IIUC, `WIN32` is still required. Sorry for not being clearer earlier.
Ugh! Yes, of course. I looked at `llvm/CMakeLists.txt` and somehow concluded that `LLVM_ENABLE_PLUGINS` is disabled if WIN32, but it is in fact the _default value_ of `LLVM_ENABLE_PLUGINS` that is set to `false` in that case. 

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D129156/new/

https://reviews.llvm.org/D129156