[PATCH] D129156: Add -fpass-plugin option to Flang

Andrzej Warzynski via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Nov 10 00:30:28 PST 2022


awarzynski added a comment.

Please be aware of https://reviews.llvm.org/D137673 - you may need to rebase if it lands before this patch.

Please just go ahead and merge, but please keep `WIN32` in the final version of "flang/test/CMakeLists.txt" (see my comment inline).

LGTM



================
Comment at: flang/test/CMakeLists.txt:65
 )
+if (NOT WIN32)
+  list(APPEND FLANG_TEST_DEPENDS Bye)
----------------
awarzynski wrote:
> IIUC, `Bye` is only needed when plugins are enabled.
IIUC, `WIN32` is still required. Sorry for not being clearer earlier.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D129156/new/

https://reviews.llvm.org/D129156



More information about the cfe-commits mailing list