[PATCH] D136953: [C++20] Diagnose invalid and reserved module names

Corentin Jabot via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Oct 28 08:09:40 PDT 2022


cor3ntin added a comment.

In D136953#3892060 <https://reviews.llvm.org/D136953#3892060>, @erichkeane wrote:

> I'll leave it to the modules experts to decide whether they're happy with this, but I had a drive-by.
>
> Also, I see none of the tests validate 'import', just 'export'.  Based on the standard, BOTH are illegal, right :D

`export module export` is perfectly ~~fine~~ conforming


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D136953/new/

https://reviews.llvm.org/D136953



More information about the cfe-commits mailing list