[PATCH] D136953: [C++20] Diagnose invalid and reserved module names

[Erich Keane via Phabricator via cfe-commits]

erichkeane added a comment.

I'll leave it to the modules experts to decide whether they're happy with this, but I had a drive-by.

Also, I see none of the tests validate 'import', just 'export'.  Based on the standard, BOTH are illegal, right :D



================
Comment at: clang/lib/Sema/SemaModule.cpp:248
+  for (auto Part : Path) {
+    int Reason = -1;
+    const IdentifierInfo *II = Part.first;
----------------
Urgh, could you make this an enum?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D136953/new/

https://reviews.llvm.org/D136953