[PATCH] D116735: [RISCV] Adjust RV64I data layout by using n32:64 in layout string

Jessica Clarke via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Oct 27 17:14:22 PDT 2022


jrtc27 added inline comments.


================
Comment at: llvm/docs/ReleaseNotes.rst:122
   been removed.
+* n32 was added to the RV64I datalayout string.
 
----------------
arichardson wrote:
> Without additional context I don't think this makes much sense to most readers. Before looking at this patch description I would not have been and to say what n is used for. 
> 
> Maybe something like "i32 has been marked as a legal integer type for RV64, improving code generation for some benchmarks"?
"native integer type" not "legal integer type"; it still gets legalised during ISel


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D116735/new/

https://reviews.llvm.org/D116735



More information about the cfe-commits mailing list