[PATCH] D134453: Disambiguate type names when printing NTTP types

[Aaron Ballman via Phabricator via cfe-commits]

aaron.ballman added a comment.

In D134453#3872355 <https://reviews.llvm.org/D134453#3872355>, @dblaikie wrote:

> But yeah, not sure/open to perspectives.
>
> @aaron.ballman - member names V type names V both?

I think type names are really the only thing that will disambiguate the expressions in some circumstances. Consider the case where there are two unrelated classes both with the same member name (like `Person::name` and `Vehicle::name`) -- having: `S<Shape{.obj = {.name = "foo"}}>` would still leave the reader guessing as to what object is actually being created without having to go chase the information down themselves.

That said, I am also curious to hear if @mizvekov has thoughts on this topic because he's been doing excellent work on template readability.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D134453/new/

https://reviews.llvm.org/D134453