[PATCH] D134453: Disambiguate type names when printing NTTP types

Erich Keane via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Oct 21 11:10:36 PDT 2022


erichkeane added subscribers: mizvekov, erichkeane.
erichkeane added a comment.

FWIW, i find the GCC diagnostics (and the application of this patch) to be much more clear/easy to read.  The pile of `{` and `}` don't really look useful/readable/meaningful to me, and leaves us ambiguous, so I'm in favor of this.

As far as the over-verbosity, I would be interested to see if we can do some additional work to make sure we use type aliases whenever possible, I believe @mizvekov has done some work in that direction, so perhaps he has commetns?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D134453/new/

https://reviews.llvm.org/D134453



More information about the cfe-commits mailing list