[PATCH] D136435: [clang][Driver] Add gcc-toolset-12 and devtoolset-12 prefixes
Fangrui Song via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Fri Oct 21 11:24:39 PDT 2022
MaskRay added a comment.
> If clang16 stops doing the gcc/devtoolset detection and relies on a config file instead, that's fine but for the time being (and for a backport to clang15), we need to fix this problem.
I think this is fine. The test removal is fine if the future direction is to remove the `Prefixes.push_back("/opt/rh/` code and rely on configuration files (https://github.com/llvm/llvm-project/issues/57843#issuecomment-1287299027).
If this is the agreed-upon direction, perhaps leave a TODO URI before `Prefixes.push_back("/opt/rh/gcc-toolset-12/root/usr");`
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D136435/new/
https://reviews.llvm.org/D136435
More information about the cfe-commits
mailing list