[PATCH] D136435: [clang][Driver] Add gcc-toolset-12 and devtoolset-12 prefixes

Timm Bäder via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Oct 21 02:44:05 PDT 2022


tbaeder created this revision.
tbaeder added reviewers: thieta, MaskRay, tstellar.
Herald added a subscriber: StephenFan.
Herald added a project: All.
tbaeder requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.

This reverts commit 35aaf548237a4f213ba9d95de53b33c5ce1eadce <https://reviews.llvm.org/rG35aaf548237a4f213ba9d95de53b33c5ce1eadce> and commit 9f97720268911abae2ad9d90e270358db234a1c1 <https://reviews.llvm.org/rG9f97720268911abae2ad9d90e270358db234a1c1> and adds the prefix like we did before.

The issues with the approach are explained in https://github.com/llvm/llvm-project/issues/57843. If clang16 stops doing the gcc/devtoolset detection and relies on a config file instead, that's fine but for the time being (and for a backport to clang15), we need to fix this problem.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D136435

Files:
  clang/lib/Driver/ToolChains/Gnu.cpp
  clang/unittests/Driver/ToolChainTest.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D136435.469521.patch
Type: text/x-patch
Size: 7022 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20221021/0d2fc4d3/attachment.bin>


More information about the cfe-commits mailing list